feat(ibdb): handle HTTP 429 rate limit responses - #1528
Open
chad3814 wants to merge 1 commit into
Open
Conversation
ibdb.dev now returns HTTP 429 with Retry-After when a client exceeds its rate limit. Previously this fell through to the generic handler and was logged at warning level with no indication of when to retry. Treat 429 like the existing 501 case: log at debug with the Retry-After value and return an empty result set so the other metadata providers still render. No sleep-and-retry, since search() is synchronous and user-facing — blocking on Retry-After would hang the metadata search UI. Adds the first unit tests for this provider, covering the 429 path (with and without a Retry-After header) plus the pre-existing 501, generic error, and success paths to pin the branch ordering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ibdb.dev now returns HTTP 429 with Retry-After when a client exceeds its rate limit. Previously this fell through to the generic handler and was logged at warning level with no indication of when to retry.
Treat 429 like the existing 501 case: log at debug with the Retry-After value and return an empty result set so the other metadata providers still render. No sleep-and-retry, since search() is synchronous and user-facing — blocking on Retry-After would hang the metadata search UI.
Adds the first unit tests for this provider, covering the 429 path (with and without a Retry-After header) plus the pre-existing 501, generic error, and success paths to pin the branch ordering.