Add admin-configurable date display format (dd/mm/yyyy support) - #1529
Open
sgreadly wants to merge 1 commit into
Open
Add admin-configurable date display format (dd/mm/yyyy support)#1529sgreadly wants to merge 1 commit into
sgreadly wants to merge 1 commit into
Conversation
- New config_date_format setting under Language & Display - Applies to book detail page (Date Added, Published, etc.) via formatdate filter - Edit Metadata date picker overlay independently derives day/month order from the same setting, recognizing %d against %m/%b/%B - Blank setting preserves existing behavior exactly (backward compatible)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the long-standing lack of dd/mm/yyyy (and other) date format support. Previously only a single generic "English" locale was available, hardcoding US-style mm/dd/yyyy-oriented display via Babel on the book detail page, and via the browser's toLocaleDateString() on the Edit Metadata page's date picker overlay.
Changes:
Known edge case: if an admin sets a format containing a month token but no %d at all (unusual, unlikely in practice), the Edit Metadata page's order-detection returns unset and falls back to the original browser-locale behaviour rather than guessing.
Changelog:
Closes #1525