Add a feature flag for derive_more impls
#970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshka
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
I'd suggest adding a small note in the commit (for future readers) that the discussion of why this change was made is in the other PR and summarize the reason.
I'm fine with this change otherwise, but will defer to @TimonPost to merge.
This adds a feature flag to allow opting out of the `derive_more` dependency and derivations added in e063091. `derive_more` brings in heavy proc macro dependencies and isn't crucial for the core functioning of crossterm, so it should be possible for a crossterm dependent to opt out of bringing in the transitive dependency.
the-mikedavis
force-pushed
the
derive-more-feature
branch
from
71a3e3b to
dfd45c4
Compare
TimonPost
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a feature flag to allow opting out of the
derive_moredependency and derivations added in #949.Currently the flag is enabled by default as it sounds useful for out-of-the-box experience for ratatui users for example - I don't have strong opinions on its default state either way.