Static analysis and ci - #7
Open
MattF-NSIDC wants to merge 17 commits into
Open
Conversation
Is context shared between steps?
Running out of ideas!
MattF-NSIDC
commented
Sep 29, 2022
| log_err() { echo -e "${red}[$(date --iso-8601=seconds)] [ERR] [${PROGNAME}] ${@}${nc}" >&2; } | ||
| log_debug() { if [[ ${debug:-} == 1 ]]; then echo -e "${yellow}[$(date --iso-8601=seconds)] [DEBUG] [${PROGNAME}] ${@}${nc}"; fi } | ||
| err_exit() { echo -e "${red}[$(date --iso-8601=seconds)] [ERR] [${PROGNAME}] ${@:-"Unknown Error"}${nc}" >&2; exit 1; } | ||
| log_info() { if [[ "${verbose:-}" == 1 ]]; then echo -e "${green}[$(date --iso-8601=seconds)] [INFO] [${PROGNAME}] ${*}${nc}"; fi; } |
Collaborator
Author
There was a problem hiding this comment.
@mankoff the $verbose variable previously had no effect. What do you think about this?
Member
There was a problem hiding this comment.
Are you sure? When processing the CLI arg/flags I had set -o xtrace; which made things very verbose. But this is a good addition.
Collaborator
Author
There was a problem hiding this comment.
Sorry, to be more clear, the --verbose flag does have an effect, but the $verbose variable was not being used anywhere in the code. We could remove the $verbose variable entirely and only do set -o xtrace when the flag is passed? What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6