Heap dump analysis#1447
Open
Josh-Matsuoka wants to merge 12 commits into
Open
Conversation
|
This PR/issue depends on: |
andrewazores
reviewed
Jun 3, 2026
andrewazores
reviewed
Jun 3, 2026
Contributor
Author
|
Following a discussion on the backend/reports design there are a few points to keep in mind:
|
Member
|
I built each heap dump analysis PR locally and ran a smoketest with last week's Agent build (see #1604): Then I captured a heap dump from the quarkus-cryostat-agent test application and tried to generate a report. The request failed with an HTTP 500. Logs from the report generator show this: At a glance I can't tell if this is a genuine case of a 1000+ deep nested structure, or if perhaps this is a recursive data structure or even modelling a simple bidirectional relationship and this is choking up the ObjectMapper. Maybe helpful: https://stackoverflow.com/questions/10191671/jackson-json-serialization-recursion-avoidance-by-level-defining |
Member
|
Looks more or less the same running the smoketest without |
Member
|
Looks like something's broken with caching. I ran Heap dump analysis worked the first time, but after navigating away and back to try to re-analyze the same file, it's failing to load the cached analysis report: |
Member
|
And after building the -reports PR and re-running |
Contributor
Author
|
CI failure is due to missing core, spotbugs passes locally |
…es, run schema update
Contributor
Author
|
Pushed an update to adjust for core changes (caller is responsible for generating and cleaning up a temporary file), as well as to update the analysis endpoint to function like the reports endpoint, returning either a job ID or a json report depending on the cache state. Spotbugs CI check failed due to core changes, passes locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to: #1127
Depends on cryostatio/cryostat-core#666
Depends on cryostatio/cryostat-reports#506
Description of the change:
How to manually test:
Opening as draft pending any changes needed for the frontend.