feat(archive): include recording labels for startTime, duration, activeRecordingId#1669
Open
andrewazores wants to merge 4 commits into
Open
feat(archive): include recording labels for startTime, duration, activeRecordingId#1669andrewazores wants to merge 4 commits into
andrewazores wants to merge 4 commits into
Conversation
andrewazores
force-pushed
the
archives-duration-id-labels
branch
from
d29432d to
22de9b5
Compare
Josh-Matsuoka
left a comment
Josh-Matsuoka
left a comment
Contributor
There was a problem hiding this comment.
Looks good once merge conflicts are fixed
andrewazores
force-pushed
the
archives-duration-id-labels
branch
from
22de9b5 to
d44cfb6
Compare
Member
Author
|
/build_test |
|
Workflow started at 6/30/2026, 11:31:10 AM. View Actions Run. |
7 tasks
|
CI build: |
andrewazores
force-pushed
the
archives-duration-id-labels
branch
from
d44cfb6 to
d831b84
Compare
Member
Author
|
@Josh-Matsuoka merge conflicts are fixed |
|
CI build: |
andrewazores
force-pushed
the
archives-duration-id-labels
branch
from
d831b84 to
9145fe5
Compare
andrewazores
force-pushed
the
archives-duration-id-labels
branch
from
9145fe5 to
4f61d67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes #1665
Description of the change:
When Cryostat archives a recording, add additional labels:
activeRecordingId, the database ID of the ActiveRecording record in the database. Along with the existingjvmIdlabel this enables complete audit log lookup of what the source recording wasduration, for a fixed-length recording this is simply the recording duration that was set. For an ongoing continuous recording this is the difference in time between when the recording was started and the moment it's being archived, or the recording'smaxAgeif it's less than that timespan.startTime, simply the timestamp when the recording was startedMotivation for the change:
See #1665 , #1605 , and cryostatio/cryostat-mcp#26 . If archived recordings are appropriately labelled so that a client (like the Cryostat MCP) can approximate the timestamp range covered by a recording file, then a series of files can be collected and concatenated to form a synthetic recording covering a wider span.
How to manually test: