Skip to content

Conversation

@vetclippy
Copy link
Contributor

@vetclippy vetclippy commented Sep 4, 2025

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

fix typo in comment

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@vetclippy vetclippy requested a review from a team as a code owner September 4, 2025 09:40
@vetclippy vetclippy requested review from songgaoye and thomas-nguy and removed request for a team September 4, 2025 09:40
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.44%. Comparing base (4094929) to head (34f26ea).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1198   +/-   ##
=======================================
  Coverage   33.44%   33.44%           
=======================================
  Files         106      106           
  Lines       15765    15765           
=======================================
  Hits         5272     5272           
  Misses       9450     9450           
  Partials     1043     1043           
Flag Coverage Δ
integration_tests 25.97% <ø> (ø)
integration_tests_byzantine 11.50% <ø> (ø)
integration_tests_gov 11.74% <ø> (ø)
integration_tests_grpc 11.74% <ø> (ø)
integration_tests_ibc 26.71% <ø> (ø)
integration_tests_ledger 11.73% <ø> (ø)
integration_tests_slow 11.73% <ø> (ø)
integration_tests_solomachine 11.54% <ø> (ø)
integration_tests_upgrade 11.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vetclippy
Copy link
Contributor Author

vetclippy commented Nov 7, 2025

@thomas-nguy Thanks for your review. I have signd this PR. Please review again.

@songgaoye songgaoye enabled auto-merge November 10, 2025 08:12
@songgaoye songgaoye added this pull request to the merge queue Nov 14, 2025
Merged via the queue into crypto-org-chain:master with commit 5471dbc Nov 14, 2025
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants