Skip to content

Conversation

@songgaoye
Copy link
Contributor

@songgaoye songgaoye commented Sep 12, 2025

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

ref crypto-org-chain/cronos-store#5

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@songgaoye songgaoye requested a review from a team as a code owner September 12, 2025 11:31
@songgaoye songgaoye requested review from XinyuCRO and thomas-nguy and removed request for a team September 12, 2025 11:31
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.29%. Comparing base (f73aab5) to head (c7c3510).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1200       +/-   ##
===========================================
+ Coverage   11.34%   36.29%   +24.94%     
===========================================
  Files         106      114        +8     
  Lines       18910    16010     -2900     
===========================================
+ Hits         2146     5811     +3665     
+ Misses      16568     9123     -7445     
- Partials      196     1076      +880     
Flag Coverage Δ
integration_tests 25.97% <100.00%> (?)
integration_tests_byzantine 11.50% <100.00%> (+0.38%) ⬆️
integration_tests_gov 11.74% <100.00%> (+0.39%) ⬆️
integration_tests_grpc 11.74% <100.00%> (+0.39%) ⬆️
integration_tests_ibc 26.71% <100.00%> (?)
integration_tests_ledger 11.73% <100.00%> (+0.40%) ⬆️
integration_tests_slow 11.73% <100.00%> (+0.40%) ⬆️
integration_tests_solomachine 11.54% <100.00%> (+0.38%) ⬆️
integration_tests_upgrade 11.74% <100.00%> (+0.39%) ⬆️
unit_tests 13.10% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added ci and removed ci labels Sep 12, 2025
@songgaoye songgaoye force-pushed the song/use_cronos_store branch 3 times, most recently from f1c3be3 to af0a887 Compare September 12, 2025 17:24
@github-actions github-actions bot added ci and removed ci labels Sep 12, 2025
@songgaoye songgaoye force-pushed the song/use_cronos_store branch from 780f284 to 39ea8ae Compare September 13, 2025 02:05
@songgaoye songgaoye marked this pull request as draft September 13, 2025 03:20
@songgaoye songgaoye force-pushed the song/use_cronos_store branch 8 times, most recently from 0651ea1 to d0415ab Compare September 15, 2025 10:06
update cronos-store

use go_1_24

update nix/sources.json

add nix_path

update nix/testenv.nix

add poetry-lock ci

use nixpksg 25.05

nix/rocksdb.nix
@socket-security
Copy link

socket-security bot commented Sep 18, 2025

@songgaoye songgaoye marked this pull request as draft September 19, 2025 02:13
@thomas-nguy thomas-nguy marked this pull request as ready for review September 30, 2025 06:35
Copy link
Contributor

@JayT106 JayT106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songgaoye songgaoye force-pushed the song/use_cronos_store branch from 24dfaec to 23ad221 Compare October 31, 2025 06:46
@randy-cro
Copy link
Contributor

suggestion for go.mod:
image

@songgaoye songgaoye force-pushed the song/use_cronos_store branch from 1a41f0c to c7c3510 Compare November 3, 2025 05:28
@songgaoye songgaoye enabled auto-merge November 3, 2025 06:26
@songgaoye songgaoye added this pull request to the merge queue Nov 3, 2025
Merged via the queue into master with commit eccfb82 Nov 3, 2025
39 checks passed
@songgaoye songgaoye deleted the song/use_cronos_store branch November 3, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants