Skip to content

Conversation

@songgaoye
Copy link
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@songgaoye songgaoye requested a review from a team as a code owner September 26, 2025 04:49
@songgaoye songgaoye requested review from XinyuCRO and thomas-nguy and removed request for a team September 26, 2025 04:49
@songgaoye songgaoye marked this pull request as draft September 26, 2025 04:49
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 55.55556% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.36%. Comparing base (5471dbc) to head (13b36a0).

Files with missing lines Patch % Lines
x/nft/client/testutil/test_helpers.go 0.00% 16 Missing ⚠️
x/nft/keeper/invariants.go 40.00% 3 Missing ⚠️
x/chainmain/module.go 0.00% 1 Missing ⚠️
x/maxsupply/module.go 0.00% 1 Missing ⚠️
x/nft-transfer/module.go 0.00% 1 Missing ⚠️
x/nft/module.go 0.00% 1 Missing ⚠️
x/supply/module.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
+ Coverage   33.44%   36.36%   +2.92%     
==========================================
  Files         106      114       +8     
  Lines       15765    16052     +287     
==========================================
+ Hits         5272     5837     +565     
+ Misses       9450     9139     -311     
- Partials     1043     1076      +33     
Flag Coverage Δ
integration_tests 26.09% <73.68%> (+0.12%) ⬆️
integration_tests_byzantine 11.65% <73.68%> (+0.14%) ⬆️
integration_tests_gov 11.89% <73.68%> (+0.14%) ⬆️
integration_tests_grpc 11.89% <73.68%> (+0.14%) ⬆️
integration_tests_ibc 26.83% <73.68%> (+0.12%) ⬆️
integration_tests_ledger 11.88% <73.68%> (+0.14%) ⬆️
integration_tests_slow 11.88% <73.68%> (+0.14%) ⬆️
integration_tests_solomachine 11.69% <73.68%> (+0.14%) ⬆️
integration_tests_upgrade 11.89% <73.68%> (+0.14%) ⬆️
unit_tests 13.23% <55.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@songgaoye songgaoye marked this pull request as ready for review November 20, 2025 05:23
@github-actions

This comment has been minimized.


// RegisterInvariants registers the capability module's invariants.
func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {}
func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} //nolint:staticcheck // invariant registry deprecated upstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this safely, same for module below

@songgaoye songgaoye changed the title feat: use cosmos-sdk v0.53 feat: use cosmos-sdk v0.53.4 Nov 20, 2025
@thomas-nguy
Copy link
Contributor

Please refer to the upgrade guide for the other changes
https://github.com/cosmos/cosmos-sdk/blob/v0.53.0/UPGRADING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants