Skip to content

Conversation

@thomas-nguy
Copy link
Collaborator

@thomas-nguy thomas-nguy commented Jun 3, 2025

Description

Closes: #

Integrate our custom changes to v53

Group them in a single commit to simplify rebase in the future


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@thomas-nguy thomas-nguy force-pushed the release/v0.53.x-mavis branch 3 times, most recently from 67a9496 to a05ea21 Compare June 3, 2025 08:49
@thomas-nguy thomas-nguy force-pushed the release/v0.53.x-mavis branch from a05ea21 to f489cad Compare June 3, 2025 10:29
@thomas-nguy thomas-nguy changed the title Problem(backport) : block-stm, object store etc Problem(v53 backport) : block-stm, object store etc Jun 4, 2025
app.finalizeBlockState.SetContext(
app.finalizeBlockState.Context().
WithBlockGasMeter(gasMeter).
WithTxCount(len(req.Txs)),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if txCount is used anywhere. cant find any usage in cronos side, maybe legacy?

@JayT106 JayT106 force-pushed the release/v0.53.x-mavis branch from e5e4243 to ae1dc9e Compare September 23, 2025 23:35
Copy link

@JayT106 JayT106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, just added a unit test fix for client/v2 module

Copy link

@JayT106 JayT106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found the cachemulti/store function doesn't match with the cronos/store. Will need to fix it.

@JayT106 JayT106 self-requested a review September 25, 2025 02:08
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants