- 
                Notifications
    
You must be signed in to change notification settings  - Fork 7
 
Problem(v53 backport) : block-stm, object store etc #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v0.53.x
Are you sure you want to change the base?
Conversation
67a9496    to
    a05ea21      
    Compare
  
    a05ea21    to
    f489cad      
    Compare
  
    | app.finalizeBlockState.SetContext( | ||
| app.finalizeBlockState.Context(). | ||
| WithBlockGasMeter(gasMeter). | ||
| WithTxCount(len(req.Txs)), | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if txCount is used anywhere. cant find any usage in cronos side, maybe legacy?
e5e4243    to
    ae1dc9e      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, just added a unit test fix for client/v2 module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found the cachemulti/store function doesn't match with the cronos/store. Will need to fix it.
| 
           This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.  | 
    
Description
Closes: #
Integrate our custom changes to v53
Group them in a single commit to simplify rebase in the future
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...