Skip to content

fix: disable memiavl cache when optimistic execution is enabled(backport) #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

fix: disable memiavl cache when optimistic execution is enabled(backport) #1890

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dfd5145
fix: disable memiavl cache when optimistic execution is enabled
songgaoye Oct 20, 2025
d118af9
Merge branch 'release/v1.4.x' into song/fix_memiavl_nil_app_mismatch
songgaoye Oct 22, 2025
d44e955
update enable optimistic execution logic
songgaoye Oct 22, 2025
c556bbb
update go.mod
songgaoye Oct 22, 2025
95573b6
update changelog
songgaoye Oct 24, 2025
2c117d8
fix comment
songgaoye Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,16 +435,19 @@ func New(
})

blockSTMEnabled := cast.ToString(appOpts.Get(srvflags.EVMBlockExecutor)) == "block-stm"
optimisticExecutionEnabled := true
Copy link
Collaborator

@thomas-nguy thomas-nguy Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you set the boolean somewhere?

Copy link
Contributor Author

@songgaoye songgaoye Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's always true( in L449 SetOptimisticExecution). I use this variable because I want to disable memiavl cache.

Copy link
Collaborator

@thomas-nguy thomas-nguy Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, is there a way to disable optimistic execution?

Copy link
Contributor Author

@songgaoye songgaoye Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!. i can add a variable like srvflags.EVMBlockExecutor disable optimistic execution.


var cacheSize int
if !blockSTMEnabled {
// only enable memiavl cache if block-stm is not enabled, because it's not concurrency-safe.
if !blockSTMEnabled && !optimisticExecutionEnabled {
// only enable memiavl cache if neither block-stm nor optimistic execution is enabled,
cacheSize = cast.ToInt(appOpts.Get(memiavlstore.FlagCacheSize))
}
baseAppOptions = memiavlstore.SetupMemIAVL(logger, homePath, appOpts, false, false, cacheSize, baseAppOptions)

// enable optimistic execution
baseAppOptions = append(baseAppOptions, baseapp.SetOptimisticExecution())
if optimisticExecutionEnabled {
Copy link
Contributor

@randy-cro randy-cro Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optimistic execution is crucial in enabling our quick blocktime though, would it be bad if we disable it?

Copy link
Collaborator

@thomas-nguy thomas-nguy Oct 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not recommend it but there is no harm to provide the option

baseAppOptions = append(baseAppOptions, baseapp.SetOptimisticExecution())
}

// NOTE we use custom transaction decoder that supports the sdk.Tx interface instead of sdk.StdTx
bApp := baseapp.NewBaseApp(Name, logger, db, txConfig.TxDecoder(), baseAppOptions...)
Expand Down
Loading