Merged
Conversation
clementblaudeau
force-pushed
the
proof-lib/fstar-support-more-rbe
branch
from
388ea32 to
ca0e85e
Compare
maximebuyse
reviewed
May 19, 2025
Contributor
maximebuyse
left a comment
maximebuyse
left a comment
There was a problem hiding this comment.
Looks generally good but I added a few commetns.
clementblaudeau
force-pushed
the
proof-lib/fstar-support-more-rbe
branch
from
2412662 to
f9e467f
Compare
Add an empty implementation for [to_string] and [debug] for any type. Might conflict in the future if specific implementations are added for some traits.
clementblaudeau
force-pushed
the
proof-lib/fstar-support-more-rbe
branch
from
f9e467f to
88782a0
Compare
Contributor
Author
|
I've rebased the PR on main. |
Member
|
@clementblaudeau what's needed to get this merged? |
Contributor
Author
|
Just approval by @maximebuyse I believe. |
Member
|
Ok, I re-requested review for you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
proof-lib/fstarrepresentation of rust core and primitives to support more ofrust-by-example.Out of the 24 sets of examples, 19 work. Proper automated testing of those example is left for a future PR.