Skip to content

Update rustc pin #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update rustc pin #1482

wants to merge 1 commit into from

Conversation

Nadrieril
Copy link
Collaborator

@Nadrieril Nadrieril commented May 28, 2025 •
edited
Loading

To fix an issue with polymorphic drops I'm planning to make a PR to rustc, so in order to be able to test the change I'm updating the rustc version we use here.

@Nadrieril Nadrieril requested a review from a team as a code owner May 28, 2025 14:23
@Nadrieril Nadrieril requested a review from W95Psp May 28, 2025 14:23
@Nadrieril Nadrieril force-pushed the update-rustc branch 2 times, most recently from 8435c0f to 30f7172 Compare May 28, 2025 17:00
@Nadrieril
Copy link
Collaborator Author

I stopped the Coq build because it was taking ages to fail uploading artifacts.

@W95Psp
Copy link
Collaborator

W95Psp commented Jun 4, 2025

Ah, yeah, the Coq job is now fixed I believe, but anyway, this indeed was not at all related to that PR in particular

W95Psp
W95Psp approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you, let's merge!

@Nadrieril Nadrieril added this pull request to the merge queue Jun 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 4, 2025
@Nadrieril Nadrieril enabled auto-merge June 4, 2025 07:32
@Nadrieril Nadrieril disabled auto-merge June 4, 2025 07:34
@Nadrieril Nadrieril enabled auto-merge June 4, 2025 07:35
@Nadrieril Nadrieril added this pull request to the merge queue Jun 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2025
@Nadrieril
Copy link
Collaborator Author

Getting the same mlkem issues as in #1467, and also don't know how to update the rustc coverage tests

@maximebuyse
Copy link
Contributor

maximebuyse commented Jun 4, 2025 •
edited
Loading

Getting the same mlkem issues as in #1467, and also don't know how to update the rustc coverage tests

There is a README in rustc-coverage-tests. To update snapshots you can run python3 run-coverage-tests.py --with-negative --check-stability --update-snapshots fstar. Maybe it would be nice to have something to do that with just. Anyway seems like updating the snapshots will not be enough as we get some fstar lax-checking failures (seems to be the usual naming issues with impl numbers that we get when we update rustc). I'll have a look and push something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nadrieril @W95Psp @maximebuyse