Skip to content

Fix detection of trait associated constants #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

Fix detection of trait associated constants #1485

merged 1 commit into from
Jun 4, 2025

Conversation

Nadrieril
Copy link
Collaborator

No description provided.

@Nadrieril Nadrieril requested a review from a team as a code owner May 30, 2025 17:05
Nadrieril
Nadrieril commented May 30, 2025
View reviewed changes
@Nadrieril
Copy link
Collaborator Author

Nadrieril commented May 30, 2025 •
edited
Loading

Charon breakage is good; we fixed an incorrectness.

@Nadrieril Nadrieril requested a review from W95Psp May 30, 2025 17:35
W95Psp
W95Psp approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nadrieril Nadrieril enabled auto-merge June 4, 2025 06:49
@Nadrieril Nadrieril added this pull request to the merge queue Jun 4, 2025
Merged via the queue into cryspen:main with commit ed3966f Jun 4, 2025
15 of 17 checks passed
@Nadrieril Nadrieril deleted the fix-constants branch June 4, 2025 07:13
@Nadrieril Nadrieril mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W95Psp W95Psp W95Psp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nadrieril @W95Psp