232 dup: feat: add new platforms to "--supported-platforms"#347
Closed
bohendo wants to merge 1 commit into
Closed
Conversation
Contributor
|
I am not sure about this solution. It looks like we are using a short term solution for a non-critical/blocking fix, that we know will require a refactoring. If we do so, we are likely to not prioritizing the proper fix, and this will increase our tech debt, and might block us in the future. I would be in favor to implement the solution from #232 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #231 I updated the wiki. also added it to the CLI since I regularly check what chains crytic-compile supports when using slither and find that useful. This PR adds non-mainnet chains with etherscan-like explorers to supported platforms. (I also fixed the spelling of
mainettomainnet)Current output of
crytic-compile --supported-platformsAfter this PR
closes #232