[CW2-53] Subcom display selection #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey chris, nice work! looks much nicer just some points
dom and I are happy to take it from here unless you had time + wanted to finish it off? |
I feel like this would work fine even if we don't get headshots of absolutely everyone, though I think people would be submitting something like that for induction anyway? Would concur on the other aesthetic comments, though yes, up to you if you'd like to keep working on it, Chris |
|
I don't know how much people would want their faces on the page, but maybe I'm thinking too deep into this |
|
new look |
Domin0de
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the list of directors and descriptions of portfolios were too long and took up a lot of vertical space on the page.
Now, a user selection menu is used to display the portfolio description + directors + subcom members in a more efficient way (inspiration from DevSoc).
Mobile responsiveness has been covered with grid breakpoints and a side-scrollable selection bar.
Currently, only director names have been filled out - subcom names, images etc. need to be populated into the data structure (but I think this may be for next year since this year is getting outducted away)?