Skip to content

Fix -a being ignored - #63

Open
pschmitt wants to merge 1 commit into
cswl:v8from
pschmitt:fix_append_path
Open

Fix -a being ignored#63
pschmitt wants to merge 1 commit into
cswl:v8from
pschmitt:fix_append_path

Conversation

@pschmitt

Copy link
Copy Markdown
Contributor

I noticed that $APPEND_SYSTEM_PATH wasn't consumed anywhere and the Android system path was appended by default. This PR makes the -a flag work as described in the help.

@cswl

cswl commented May 31, 2020

Copy link
Copy Markdown
Owner

I should probably document this code... but this is intended..

The reason still being issue with some Android devices unable to load /system/binaries due to library linking error

@pschmitt

Copy link
Copy Markdown
Contributor Author

Wouldn't it make more sense to remove the flag altogether then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants