This repository was archived by the owner on Jun 3, 2019. It is now read-only.
RenderToNodeStream #525
Closed
RenderToNodeStream #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ender deprecates in 17.
…dir, as its no longer an option. HappyPack threadpool now is decided based off of os.cpus().length
…vious addons packages. moved meta charSet above title in html template
…adapter-react-16 and a setupFile for jest tests
…o satisfy airbnb peer dep
* switch reactdom.render to reactdom.hydrate as per react 16 changes. render deprecates in 17. * remove extraneous babel-polyfill * Update dependencies, included is HappyPack 4. Removed Happypack temp dir, as its no longer an option. HappyPack threadpool now is decided based off of os.cpus().length * remove react-addons-test-utils as React 16 doesnt use any form of previous addons packages. moved meta charSet above title in html template * Add requestAnimationFrame (raf) polyfill. Upgrade enzyme. Add enzyme-adapter-react-16 and a setupFile for jest tests * bump react-hot-loader to beta 7. downgrade eslint/jsx-a11y to 5.1.1 to satisfy airbnb peer dep
* Minor readme updates (ctrlplusb#501) * Update Webpack version * Update Webpack version * Fix acronym * Fix markdown formatting. * Update that redux branch does not have Flow * Add 'Who is using it' section in the README As per @ctrlplusb’s comment here: ctrlplusb#437 (comment) 98854669 * Server logging enhancements (ctrlplusb#508) * Improving logging experience + consolidating to single log function * Adding pretty-error for more readable node error stack * Fix eslint error * Logging requests received * Re-commit logging requests received * Replacing colors with chalk
# Conflicts: # internal/utils.js # package-lock.json # package.json
SleepWalker
reviewed
Oct 16, 2017
| import { StaticRouter } from 'react-router-dom'; | ||
| import { AsyncComponentProvider, createAsyncContext } from 'react-async-component'; | ||
| import asyncBootstrapper from 'react-async-bootstrapper'; | ||
| import React from "react"; |
There was a problem hiding this comment.
Why do you use double quotes? Have you linted your code?
There was a problem hiding this comment.
Looks like prettier didn't run properly? FYI all I have updated prettier. We no longer use prettier-eslint. Just use native prettier and eslint separately. I installed the eslint-config-prettier plugin which disables all the style rules so we can still use the airbnb config.
|
Thanks for picking this up @strues - would you mind rebasing this PR or creating a new one and cherry picking the commits from this one? I'd like us to start running PRs using a rebase strategy to avoid noise. |
|
I'll recreate and rebase top of the most recent |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ReactDOM.RenderToNodeStream for server rendering (issue #524)