Skip to content

[JUnit Platform] Don't require global read lock #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −16
Draft

[JUnit Platform] Don't require global read lock #3103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cucumber-junit-platform-engine/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<properties>
<hamcrest.version>3.0</hamcrest.version>
<junit-jupiter.version>5.14.0</junit-jupiter.version>
<junit-jupiter.version>6.1.0-SNAPSHOT</junit-jupiter.version>
Copy link
Contributor Author

@mpkorstanje mpkorstanje Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Snapshot version. Wait for release, and upgrade Cucumber to JUnit 6.

</properties>

<dependencyManagement>
Expand Down
30 changes: 15 additions & 15 deletions ...atform-engine/src/main/java/io/cucumber/junit/platform/engine/CucumberTestDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,11 @@ protected URI getUri() {
protected Location getLocation() {
return feature.getLocation();
}

@Override
public boolean isGlobalReadLockRequired() {
return false;
}
}

abstract static class FeatureElementDescriptor extends CucumberTestDescriptor
Expand Down Expand Up @@ -197,6 +202,16 @@ protected URI getUri() {
return element.getUri();
}

@Override
public Type getType() {
return Type.CONTAINER;
}

@Override
public boolean isGlobalReadLockRequired() {
return false;
}

static final class ExamplesDescriptor extends FeatureElementDescriptor {

ExamplesDescriptor(
Expand All @@ -206,11 +221,6 @@ static final class ExamplesDescriptor extends FeatureElementDescriptor {
super(configuration, uniqueId, name, source, element);
}

@Override
public Type getType() {
return Type.CONTAINER;
}

}

static final class RuleDescriptor extends FeatureElementDescriptor {
Expand All @@ -222,11 +232,6 @@ static final class RuleDescriptor extends FeatureElementDescriptor {
super(configuration, uniqueId, name, source, element);
}

@Override
public Type getType() {
return Type.CONTAINER;
}

}

static final class ScenarioOutlineDescriptor extends FeatureElementDescriptor {
Expand All @@ -238,11 +243,6 @@ static final class ScenarioOutlineDescriptor extends FeatureElementDescriptor {
super(configuration, uniqueId, name, source, element);
}

@Override
public Type getType() {
return Type.CONTAINER;
}

}
}

Expand Down
Loading