php: Require PHP 8.2 in composer.json#229
Merged
mpkorstanje merged 32 commits intocucumber:mainfrom Feb 5, 2026
Merged
Conversation
Contributor
Author
|
Try updating PHP dev deps - that is: try with a 4.x dep, and now the conflict So I'd like a psalm that supports php-parser 5. |
Contributor
|
@ciaranmcnulty do you think we have a prayer at upgrading this? |
Contributor
Author
|
@mpkorstanje To me, it seemed like psalm isn't yet ready, but perhaps we can make it ready, by creating a psalm that supports the new parser version? |
Contributor
|
Thanks for looking into this. It looks like PHP 8.1 will still get updates so I think we can wait for Psalm to upgrade their parser. |
Contributor
|
It starts to work again on PHP 8.3 but does come with a lot of new problems found by Psalm. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #228.
NEEDS to wait for Psalm to release a version that supports php-parser v5.
🤔 What's changed?
Make the dependency on a non-EOL'd PHP version manifest in composer.json.
⚡️ What's your motivation?
A good comment in #228.
🏷️ What kind of change is this?