Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add libpsl to the build #48

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Makefile: add libpsl to the build #48

merged 2 commits into from
Jan 16, 2024

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 15, 2024

Fixes #47

I'm throwing myself off this cliff. Tell me all my errors and mistakes done here!

@bagder bagder requested a review from xquery January 15, 2024 17:28
Copy link

@dfandrich dfandrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build_fedora section (line 31) will probably need "libpsl-devel" added.

a Dan Fandrich suggestion
Copy link
Member

@xquery xquery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and thx!)

@xquery xquery merged commit 9414d81 into main Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure build with libpsl
3 participants