fix incompatible type for props cli arg #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type checking error in the builder module by updating the data type of a dictionary value from boolean to string. The change addresses a mypy error that occurred after the props attribute type was updated in a previous commit to expect string values instead of mixed types.
- Updates the debug property value from boolean
Trueto string"true"to match expected type
Co-authored-by: Copilot <[email protected]>
|
@sleepy-monax if I may, do you expect |
Helps resolve linting errors when running github actions
|
hey @sleepy-monax, you wanna take a look here please? |
the literal is a substring of resolved.reason
the literal is a substring in the reason
|
@fynnwilliam thanks for all the fixes, I'll merged:) |
|
you are welcome @sleepy-monax |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves type checking error when running github actions
Data type for
propswas updated incommite9d1428 hence a need for this change