-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for the GET /api/tasks/<id>/status
API
#9076
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9076 +/- ##
===========================================
+ Coverage 73.75% 73.91% +0.16%
===========================================
Files 428 428
Lines 44514 44498 -16
Branches 3881 3881
===========================================
+ Hits 32830 32890 +60
+ Misses 11684 11608 -76
|
Before merging this PR, we need to switch the Exchange Oracle from Human Protocol to the |
I'll convert it to draft then, to prevent mistakes. Please convert it back when it's safe to merge. |
expected_task_creation_status_state='finished', | ||
expected_task_creation_status_reason=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you could change "status" to "request"/"rq" here? Seems like it would match the terminology better.
98f02f3
to
5a343b1
Compare
/check |
❌ Some checks failed |
|
Motivation and context
The GET
/api/tasks/<id>/status
API endpoint was previously deprecated in favor of GET/api/requests/<rq_id>
Extracted from #9075
How has this been tested?
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.