Remove unnecessary files from Docker images #9119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecLad
force-pushed
the
cleanup-dockerfile
branch
from
b1748af to
fb54db2
Compare
* The ones in `Dockerfile` appears to be a remnant of a feature deleted in cvat-ai#1767. * The ones in `Dockerfile.ci` are irrelevant since cvat-ai#6173 and cvat-ai#8985.
SpecLad
force-pushed
the
cleanup-dockerfile
branch
from
fb54db2 to
fb24343
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9119 +/- ##
===========================================
- Coverage 73.97% 73.83% -0.15%
===========================================
Files 430 431 +1
Lines 44631 44807 +176
Branches 3892 3892
===========================================
+ Hits 33017 33084 +67
- Misses 11614 11723 +109
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The ones in
Dockerfileappears to be a remnant of a feature deleted in DL models as serverless functions #1767.The ones in
Dockerfile.ciare irrelevant since Code coverage #6173 and Remove jest tests from cvat-core #8985.How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
[ ] I submit my code changes under the same MIT License that covers the project.Feel free to contact the maintainers if that's a concern.