Fix issue scaling on image filter appication #9126
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Currently we have such a problem:

The issue occurs when applying an image filter. The bug follows these steps:
canvas.configure()
.canvas.configure()
,canvas.fit()
is called (likely to maintain zoom and position even when switching to an image with a different resolution).canvas.fit()
dispatches acanvas.fit
event, which the issues component listens to. As a result, the issues component receives the default zoom, causing issue elements to appear larger than expected.To fix this, I extracted the scale reset into a separate method. There's no need to dispatch the
fit
event insidecanvas.configure()
, as inside of it we need to reset the scale to base parameters before adjusting it withrelativeScaling
How has this been tested?
Checklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.