-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactoring] Update id naming convention #9206
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9206 +/- ##
===========================================
- Coverage 74.14% 74.13% -0.01%
===========================================
Files 428 428
Lines 44973 44971 -2
Branches 3917 3917
===========================================
- Hits 33345 33340 -5
- Misses 11628 11631 +3
🚀 New features to boost your workflow:
|
|
First of all, I can't remember any discussions regarding naming conventions. Anyway, we may follow Id, or ID, it is discussable (chat GPT recommends using
|
Motivation and context
For a long time we now have been using
*ID
naming convention for id variables, but in some code that was added before this, some variables keep*Id
naming convention. This PR tries to unify it.How has this been tested?
Checklist
develop
branch[ ] I have created a changelog fragment-~~ [ ] I have updated the documentation accordingly~~
[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.