Skip to content

Feat: Adding option to specify the package manager version that you want #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ramykl
Copy link
Contributor

@ramykl ramykl commented Sep 12, 2024

This will make it possible to install a specific version of a package manager through the cypress orb

@cypress-app-bot
Copy link
Collaborator

@ramykl ramykl force-pushed the rl/package-manager-version branch from 313a196 to 9a25dc8 Compare September 12, 2024 08:31
@ramykl ramykl changed the title Adding option to specify the package manager version that you want Feat: Adding option to specify the package manager version that you want Sep 18, 2024
@MikeMcC399 MikeMcC399 added the type: enhancement New feature or request label Oct 2, 2024
@deiga
Copy link
Contributor

deiga commented Oct 7, 2024

Could this also support using bun https://bun.sh/?

@MikeMcC399

This comment was marked as off-topic.

@ramykl ramykl force-pushed the rl/package-manager-version branch 2 times, most recently from e241bd6 to 352bca5 Compare November 4, 2024 14:24
@ramykl
Copy link
Contributor Author

ramykl commented Nov 4, 2024

@jennifer-shehane I think this will also fix the failing pnpm test you mentioned here #485 (comment) but I created a specific PR just for that fix as well #492

@MikeMcC399

This comment was marked as resolved.

MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Collaborator

Would you like to give some feedback about whether you want to continue with this PR?

It looks like the pnpm process is working now without needing to specify the pnpm version (it's just using the latest version by default).

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Nov 15, 2024

Both pnpm and Yarn allow settting the package manager using corepack in current versions, so there seems to be some overlap between selecting the package manager version through the Orb and selecting it through the project configuration.

Edit: Updated for pnpm@10 release

@ramykl
Copy link
Contributor Author

ramykl commented Nov 18, 2024

@MikeMcC399 Sorry, will look at fixing this during the week. Have had a busy few weeks.

@ramykl ramykl force-pushed the rl/package-manager-version branch from 1310415 to 41eb6a7 Compare November 19, 2024 11:15
@MikeMcC399

This comment was marked as resolved.

@ramykl
Copy link
Contributor Author

ramykl commented Jan 28, 2025

@jennifer-shehane any updates on being to get this merged

@MikeMcC399
Copy link
Collaborator

@ramykl

Check if https://pnpm.io/npmrc#manage-package-manager-versions meets your needs for pnpm. It is enabled by default.

image

@MikeMcC399

This comment was marked as resolved.

@MikeMcC399
Copy link
Collaborator

@ramykl

5 of the 6 failing checks are due to the PR coming from a fork which is not set up to record to Cypress Cloud.

You passed the --record flag but did not provide us your Record Key

The failure in "ci/circleci: Yarn Version Example" is however not due to a problem with recording:

https://app.circleci.com/pipelines/github/ramykl/circleci-orb/40/workflows/2d986fbc-3f2b-41cc-b76b-8c02b1468fe8/jobs/179

Job "Install Yarn" fails with:

Selected version of Yarn is 1.22.5
Checking if YARN is already installed...
A different version of Yarn is installed (1.22.19); removing it
^@^@rm: cannot remove '/usr/local/bin/yarn': Permission denied

Exited with code exit status 1

@MikeMcC399
Copy link
Collaborator

@ramykl

Are you planning to work on the failure mentioned in #486 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants