-
Notifications
You must be signed in to change notification settings - Fork 393
Add node 22, chrome 134, and ff138 images for base-internal and browsers-internal #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Mike McCready <[email protected]>
README.md
Outdated
| [Google Chrome][chrome] | :white_check_mark: | see [#1188](https://github.com/cypress-io/cypress-docker-images/issues/1188) | | ||
| [Mozilla Firefox][firefox] | :white_check_mark: | :white_check_mark: | | ||
| [Microsoft Edge][edge] | :white_check_mark: | see [#1189](https://github.com/cypress-io/cypress-docker-images/issues/1189) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't make these case changes in your internal PR.
The case is only used internally.
All the visible names are correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier did this automatically - I'll revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check for Prettier separately! Thanks for explaining where it came from and for reverting.
package.json
Outdated
@@ -33,5 +33,5 @@ | |||
"globals": "^16.0.0", | |||
"markdown-link-check": "3.12.2", | |||
"prettier": "3.5.3" | |||
} | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}, | |
} |
I missed removing the comma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
I don't know what happened with Prettier. It's not asking for any format changes when I run it here.
CircleCI is happy as well: |
For Corepack you can set I also added an enhancement request to ask Corepack NOT to change the package manager on its own, like here from npm to Yarn. There are several other related enhancement requests for Corepack to change some of this and make it more user-friendly, however it looks like nobody is working on Corepack anymore since the Node.js TSC decided to stop distributing Corepack with Node.js 25 and above, so I don't know if it will ever get looked at. |
It looks like you must have had an old 2.x version of Prettier globally installed when you ran Prettier. If you run There was a bug in Prettier 2.x where Markdown links were incorrectly changed to lowercase. One of the Corepack maintainers has changed the auto-pin to be non-default. Hopefully that will get released soon and prevent accidental changes to package.json files! |
This is in preparation for Electron 35.