-
Notifications
You must be signed in to change notification settings - Fork 3.3k
internal: (studio) capture anonymous telemetry for studio initialization #31555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
Project |
cypress
|
Branch Review |
studio-event-capture
|
Run status |
|
Run duration | 19m 11s |
Commit |
|
Committer | astone123 |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
9
|
|
1232
|
|
0
|
|
32149
|
View all changes introduced in this branch ↗︎ |
UI Coverage
46.2%
|
|
---|---|
|
186
|
|
164
|
Accessibility
92.7%
|
|
---|---|
|
3 critical
8 serious
2 moderate
2 minor
|
|
887
|
…n errors, remove references for isStudioProtocolEnabled
ryanthemanuel
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work on this!
ryanthemanuel
approved these changes
Apr 29, 2025
mabela416
approved these changes
Apr 29, 2025
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related services PR https://github.com/cypress-io/cypress-services/pull/10689
Additional details
We'd like to know how many people are using Cypress Studio today. This PR adds logic on the app side to call a method that will record an event when a user opens up Studio. We will send their anonymous
machineId
, browser info, and Cloud user info if they are logged into Cypress Cloud.Steps to test
Ensure that studio still loads correctly - the cloud studio panel should still load when you pass the correct environment variables, and it should not when these variables are not provided.
Check the tests that I added that verify that the cloud code to collect telemetry is always called when Studio loads even if AI is not enabled.
Run services with this branch, start the app with
CYPRESS_INTERNAL_ENV=development CYPRESS_LOCAL_STUDIO_PA TH=../cypress-services/app/packages/studio/dist/development
set (replaceCYPRESS_LOCAL_STUDIO_PATH
with where you have cypress-services cloned to)See services PR for further testing instructions.
How has the user experience changed?
Users shouldn't notice any changes to how Studio works today - the external user experience should remain unchanged.
PR Tasks
cypress-documentation
?type definitions
?