chore(system-tests): retry Docker image pulls on transient registry errors#34147
Open
cursor[bot] wants to merge 1 commit into
Open
chore(system-tests): retry Docker image pulls on transient registry errors#34147cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
binary-system-tests failed on develop (19ac719) when Docker Hub returned HTTP 500 for cypress/base:25.0.0. Add exponential backoff retries to DockerProcess.pull() so transient registry failures do not fail the suite. Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com>
Collaborator
|
jennifer-shehane
changed the title
AtofStryker
reviewed
Jun 26, 2026
| return | ||
| } catch (err) { | ||
| lastError = err | ||
| if (attempt < maxAttempts) { |
Collaborator
There was a problem hiding this comment.
This makes sense to me. Do we have a way to unit test this and verify it works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Develop CI for commit
19ac719failedbinary-system-testswhen Docker Hub returned HTTP 500 while pullingcypress/base:25.0.0. This blockedready-to-releaseeven though the merged PR (#34141) only removed a duplicate webpack-dev-server test invocation.Add retry with exponential backoff to
DockerProcess.pull()so transient Docker registry failures do not fail the binary system test suite.Additional details
Failure excerpt from
binary-system-testsjob #3735965:prePullImagesalready usesallSettled, but individual test runs callpull()again viadockerSpawner. Retries are applied at the pull level (3 attempts, 2s/4s backoff).Unrelated failures on the same pipeline (Windows
port 4455conflict and studio UI flake) are not addressed here.Steps to test
binary-system-testsCI job on next develop run.How has the user experience changed?
No change
PR Tasks
cypress-documentation?type definitions?Note
Low Risk
CI harness-only change; no production runtime, auth, or user-facing behavior.
Overview
Docker image pulls in system tests now retry instead of failing on the first registry error (e.g. Docker Hub HTTP 500).
The previous single-shot pull logic is moved to
pullOnce().pull()runs up to 3 attempts by default, logging failures and waiting 2s then 4s between tries before rethrowing the last error. Call sites such asdockerSpawnerandprePullImageskeep callingpull(), so binary system tests get retries without other harness changes.Reviewed by Cursor Bugbot for commit 1f044fd. Bugbot is set up for automated code reviews on this repo. Configure here.