Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: exclude builds from eslint checks #1396

Merged

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Mar 10, 2025

Issue

Each of the following examples includes a build script definition which, if run, generates additional files, including JavaScript *.js files:

Assessment

ESLint does not respect the .gitignore files in the monorepo.

Including .gitignore Files describes how to use a compatibility utility to work around this restriction, however it is less complicated to use ESLint's global ignore instead, and it requires no additional dependency.

Change

Add ESLint linting ignore to eslint.config.mjs for:

  • examples/component-tests/dist
  • examples/nextjs/.next
  • examples/wait-on-vite/dist

Verification

git clean -xfd
npm ci
cd examples/component-tests
npm ci
npm run build
cd ../nextjs
npm ci
npm run build
cd ../wait-on-vite
npm ci
npm run build
cd ../..
npx eslint

Confirm that no linting issues are reported.

@MikeMcC399 MikeMcC399 added the ci label Mar 10, 2025
@MikeMcC399 MikeMcC399 self-assigned this Mar 10, 2025
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 changed the title chore: exclude builds from eslint checks ci: exclude builds from eslint checks Mar 10, 2025
@MikeMcC399 MikeMcC399 force-pushed the eslint-exclude-builds branch from cac65fd to d124a5a Compare March 10, 2025 15:02
@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 10, 2025 15:07
@jennifer-shehane jennifer-shehane merged commit 8a2d31f into cypress-io:master Mar 10, 2025
74 checks passed
@MikeMcC399 MikeMcC399 deleted the eslint-exclude-builds branch March 10, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants