Skip to content

Conversation

@slr71
Copy link
Member

@slr71 slr71 commented May 29, 2025

…rary

https://github.com/streadway/amqp is no longer maintained, and a new fork has been created at https://github.com/rabbitmq/amqp091-go. The primary purpose of this change is to switch to the new library. While I was making changes, I also updated other dependencies.

Note: this does introduce a breaking change. QueueInspect method is deprecated, and the suggestion is to call QueueDeclarePassive instead. Unfortunately, QueueDeclarePassive requires more parameters, and I changed the function signature in order to add the relevant parameters.

@socket-security
Copy link

socket-security bot commented May 29, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgo.opentelemetry.io/​otel@​v1.35.0 ⏵ v1.36.075 +1100100100100
Addedgithub.com/​rabbitmq/​amqp091-go@​v1.10.098100100100100
Updatedgo.opentelemetry.io/​otel/​trace@​v1.35.0 ⏵ v1.36.0100 +1100100100100

View full report

Copy link
Member

@ianmcorvidae ianmcorvidae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Took a bit for me to understand the QueueInspect vs. QueueDeclarePassive thing, so linking the reasoning from the upstream library a bit: rabbitmq/amqp091-go#167 and rabbitmq/amqp091-go#165 -- it looks like since QueueInspect assumed no special parameters it would fail on some queues that set those parameters. Once adding support for those parameters it's exactly identical to QueueDeclarePassive, so all seems well with these changes!

I'm not sure how much of a pain it'll be to update services using this. Hopefully not too bad or at least hopefully mostly just updating the imports. I suppose one way or another we'll see.

@slr71
Copy link
Member Author

slr71 commented May 30, 2025

Thanks for the review and for the links! Yeah, I'm hoping that migrating to the new function signature won't be too painful.

@slr71 slr71 merged commit b9c070c into cyverse-de:main May 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants