Skip to content

[Fix Bug] Choice option not change when the component triggering by other component dynamically. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
home3k wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Fix Bug] Choice option not change when the component triggering by other component dynamically. #8

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d01ca9
fix
home3k Aug 3, 2016
214f6c7
fix
home3k Aug 3, 2016
bb18074
fix
home3k Aug 4, 2016
fc6696d
kick console.
home3k Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 41 additions & 39 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,17 @@ const defaultProps = {
options: [],
selectedOptions: [],
onSelection(option){},
style:{},
optionStyle:{},
disabled: false
style:{},
optionStyle:{},
disabled: false
};

class MultipleChoice extends BaseComponent {

constructor(props) {
super(props);

const ds = new ListView.DataSource({rowHasChanged: (r1, r2) => true});
const ds = new ListView.DataSource({rowHasChanged: (r1, r2) => r1 !== r2})
this.ds = ds;

this.state = {
Expand All @@ -49,23 +49,23 @@ class MultipleChoice extends BaseComponent {
};

this._bind(
'_renderRow',
'_selectOption',
'_isSelected',
'_updateSelectedOptions'
'_renderRow',
'_selectOption',
'_isSelected',
'_updateSelectedOptions'
);
}

componentWillReceiveProps(nextProps) {
this._updateSelectedOptions(nextProps.selectedOptions);
this._updateSelectedOptions(nextProps.selectedOptions, nextProps.options);
this.setState({
disabled: nextProps.disabled
});
}
_updateSelectedOptions(selectedOptions) {
_updateSelectedOptions(selectedOptions, options) {
this.setState({
selectedOptions,
dataSource: this.ds.cloneWithRows(this.props.options)
dataSource: options ? this.ds.cloneWithRows(options) : this.ds.cloneWithRows(this.props.options)
});
}

Expand Down Expand Up @@ -109,11 +109,11 @@ class MultipleChoice extends BaseComponent {
}

return (
<Image
style={Styles.optionIndicatorIcon}
source={require('./assets/images/check.png')}
/>
);
<Image
style={Styles.optionIndicatorIcon}
source={require('./assets/images/check.png')}
/>
);
}
}

Expand All @@ -136,6 +136,7 @@ class MultipleChoice extends BaseComponent {
}

_renderRow(option) {
console.log('render row', option)

if(typeof this.props.renderRow === 'function') {
return this.props.renderRow(option);
Expand All @@ -144,33 +145,34 @@ class MultipleChoice extends BaseComponent {
const disabled = this.state.disabled;
return (

<View style={this.props.optionStyle}>
<TouchableOpacity
activeOpacity={disabled ? 1 : 0.7}
onPress={!disabled ? ()=>{this._selectOption(option)} : null}
>
<View>
<View
style={Styles.row}
>
<View style={Styles.optionLabel}>{this._renderText(option)}</View>
<View style={Styles.optionIndicator}>{this._renderIndicator(option)}</View>
</View>
</View>
</TouchableOpacity>
{this._renderSeparator(option)}
</View>
);
<View style={this.props.optionStyle}>
<TouchableOpacity
activeOpacity={disabled ? 1 : 0.7}
onPress={!disabled ? ()=>{this._selectOption(option)} : null}
>
<View>
<View
style={Styles.row}
>
<View style={Styles.optionLabel}>{this._renderText(option)}</View>
<View style={Styles.optionIndicator}>{this._renderIndicator(option)}</View>
</View>
</View>
</TouchableOpacity>
{this._renderSeparator(option)}
</View>
);
}

render() {
return (
<ListView
style={[Styles.list, this.props.style]}
dataSource={this.state.dataSource}
renderRow={this._renderRow}
/>
);
<ListView
enableEmptySections={true}
style={[Styles.list, this.props.style]}
dataSource={this.state.dataSource}
renderRow={this._renderRow}
/>
);
}
};

Expand Down