Fix matrix dimensions in gradient rules for x^T A#2721
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
The gradient of x^T A requires A in R^{n x m}, not the same m x n
shape as for A x. Split the combined rule into two cases with correct
dimensions.
Fixes d2l-ai#2632
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A xandx^T Ainto two cases with correct matrix dimensionsx^T ArequiresA \in R^{n \times m}, not the samem \times nshape as forA xIssues addressed
Fixes #2632
Test plan
Made with Cursor