fix: use HTTPS and safe tar extraction for dataset downloads#2723
Open
Chessing234 wants to merge 1 commit into
Open
fix: use HTTPS and safe tar extraction for dataset downloads#2723Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Switch DATA_URL to HTTPS and reject path-traversal tar members when extracting datasets, preventing tar-slip arbitrary file writes from MITM-compromised downloads. Fixes d2l-ai#2714. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2714
Summary
DATA_URLfrom HTTP to HTTPS across all framework utility modules_safe_tar_extract()to reject path-traversal tar members (uses Python 3.12+datafilter when available)extract()anddownload_extract()Test plan
../member pathsd2l/torch.py,mxnet.py,tensorflow.py, andjax.pyMade with Cursor