webpack dev server #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2018 11:46
ghost
changed the title
ghost
requested a review
from 
JakeSidSmith
suggested changes
Oct 9, 2018
Contributor
JakeSidSmith
left a comment
JakeSidSmith
left a comment
There was a problem hiding this comment.
You need some tests for the new config. E.g. check that the publicPath is constructed correctly.
src/index.js
Outdated
| output: { | ||
| filename: outFile, | ||
| path: outDir, | ||
| publicPath: options.outDir.replace(MATCHES_LEADING_DOT_SLASHES, ''), |
Contributor
There was a problem hiding this comment.
You should add this option only to devServer
https://webpack.js.org/configuration/dev-server/#devserver-publicpath-
src/index.js
Outdated
| ]; | ||
|
|
||
| const HOST = '0.0.0.0'; | ||
| const PORT = 3000; |
Contributor
There was a problem hiding this comment.
You should pull these from process.env, and have these as default values.
const { HOST = '0.0.0.0', PORT = 3000 } = process.env; …ocess.env and specify default values
…k-config into webpack-dev-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional settings for webpack dev server