Don't hide entities from GM screen radar#2824
Open
oznogon wants to merge 2 commits intodaid:masterfrom
Open
Conversation
Bypass the early exit in BasicRadarRendering::renderOnRadar() for LongRange-only traces if the radar system is flagged as GM (GM screen, Spectate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bypass the early exit in
BasicRadarRendering::renderOnRadar()for LongRange-only traces if the radar system is flagged as GM (GM screen, Spectate).This fixes the regression of LongRange traces not rendering on the GM screen, where those entities are still selectable but invisible. This also doesn't change the behavior of not rendering them on Science radar, Probe View radar, or Relay's shared short-range radar, which is intentional per #2821.
GM screen before: LongRange-flagged traces aren't visible, but the entities are still selectable
Screen.Recording.2026-03-31.091647.mp4
GM screen after: LongRange-flagged traces are visible
Screen.Recording.2026-03-31.091458.mp4