fix(python): isolate launch environments#681
Open
Cloudymap1e wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #304
Description
launch_options()reused and mutated eitheros.environor the caller-providedenvmapping while configuring virtual-display settings. A virtual launch could therefore leaveDISPLAYand Wayland overrides behind for later headed launches.This change snapshots the selected environment before applying per-launch overrides, so each sync or async launch receives an isolated mapping and caller-owned state remains unchanged.
Type of Change
Testing
python -m pytest pythonlib/tests/test_launch_environment.py -q: 2 passedpython -m pytest pythonlib/tests -q: 45 passed, 4 skippedFingerprint Report
Not applicable: this is a Python launch-environment change and does not alter the browser binary or fingerprint patches.
Checklist
Service tests pass (for python library changes) -temporarily out of service lol./service-tester/run_tests.sh --browser-version official/prerelease/146.0.1-alpha.25(attach screenshot)