Skip to content

feat: Add NetEvolve.HealthChecks.Azure.KeyVault#1635

Open
Copilot wants to merge 5 commits intomainfrom
copilot/create-health-checks-azure-key-vault
Open

feat: Add NetEvolve.HealthChecks.Azure.KeyVault#1635
Copilot wants to merge 5 commits intomainfrom
copilot/create-health-checks-azure-key-vault

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 26, 2026

  • Create src/NetEvolve.HealthChecks.Azure.KeyVault/ project
  • Add Azure.Security.KeyVault.Secrets 4.7.0 and AzureKeyVaultEmulator.TestContainers 2.3.3 to Directory.Packages.props
  • Add project to HealthChecks.slnx
  • Add unit tests to tests/NetEvolve.HealthChecks.Tests.Unit/Azure.KeyVault/
  • Add integration tests to tests/NetEvolve.HealthChecks.Tests.Integration/Azure.KeyVault/
  • Update unit and integration test .csproj files with new project references
  • Fix CI: add missing .testgroup file (Z02TestGroup) required by Collect-TestProjects.ps1
  • Fix CI: reformat 11 files with CSharpier to pass code formatting check
Original prompt

This section details on the original issue you should resolve

<issue_title>NetEvolve.HealthChecks.Azure.KeyVault</issue_title>
<issue_description>### Project Name

Azure.KeyVault

Project Description

Health check for Azure Key Vault.

TestContainer Package Required?

Yes

TestContainer Package Name

AzureKeyVaultEmulator.TestContainers

Required NuGet Dependencies

Azure.Identity
Azure.Security.KeyVault.Secrets

Validation Steps

  • Create project structure in src/NetEvolve.HealthChecks.<ProjectName>/
  • Follow naming conventions from decision documentation
  • Include a clear README.md describing the project purpose
  • Restore NuGet packages (dotnet restore)
  • Build the solution (dotnet build --no-restore)
  • Add unit tests to tests/NetEvolve.HealthChecks.Tests.Unit/<ProjectName>/ folder
  • Add integration tests to tests/NetEvolve.HealthChecks.Tests.Integration/<ProjectName>/ folder
  • Run project-specific tests (dotnet test --filter FullyQualifiedName~<ProjectName>)
  • Verify all tests pass successfully

Additional Notes

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

Custom agent used: C# Expert
An agent designed to assist with software development tasks for .NET projects.


📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] Add health check for Azure Key Vault feat: Add NetEvolve.HealthChecks.Azure.KeyVault Mar 26, 2026
Copilot AI requested a review from samtrion March 26, 2026 09:08
@samtrion samtrion force-pushed the copilot/create-health-checks-azure-key-vault branch from c798c31 to 01e28e7 Compare March 26, 2026 16:33
@samtrion
Copy link
Copy Markdown
Contributor

@copilot Fix issues found in the pipeline

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 26, 2026

@copilot Fix issues found in the pipeline

Fixed in commit 6d9435a. Two issues were causing the pipeline failures:

  1. Missing .testgroup fileCollect-TestProjects.ps1 requires a .testgroup file in every integration test subdirectory. Added tests/NetEvolve.HealthChecks.Tests.Integration/Azure.KeyVault/.testgroup with content Z02TestGroup.

  2. CSharpier formatting violations — 5 files had formatting that didn't match the project's CSharpier style (constructor parameters, lambda bodies, generic type formatting). Ran csharpier format across all new files to fix them.

@samtrion samtrion marked this pull request as ready for review April 5, 2026 13:56
@samtrion samtrion requested a review from a team as a code owner April 5, 2026 13:56
@samtrion samtrion force-pushed the copilot/create-health-checks-azure-key-vault branch from 6d9435a to 8c75c52 Compare April 8, 2026 20:48
samtrion added 3 commits April 9, 2026 00:01
Enhanced the Key Vault secret health check to verify both the timeliness and success of secret retrieval. Now returns an unhealthy status if secrets cannot be retrieved, ensuring more accurate health reporting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NetEvolve.HealthChecks.Azure.KeyVault

2 participants