fix(shared): preserve card sequence with in-feed reminder hero by tomeredlich · Pull Request #5780 · dailydotdev/apps

tomeredlich · 2026-03-23T12:49:03Z

Summary

adjust in-feed hero insertion index to account for pre-feed slot cards (brief/profile completion)
keep hero rendering in flow while preserving card sequence and row boundaries
scope change to feed placement logic only (Feed.tsx)

Test plan

Run pnpm --filter shared exec eslint \"src/components/Feed.tsx\"
On homepage, verify in-feed hero appears in its own row
Confirm cards before/after hero keep correct sequence with no missing items
Verify behavior remains correct when brief/profile completion first slot is present

Made with Cursor

Preview domain

https://fix-in-feed-hero-row-sequence.preview.app.daily.dev

Adjust in-feed hero insertion index to account for pre-feed slot cards so the hero renders in its own row without breaking card order. Made-with: Cursor

vercel · 2026-03-23T12:49:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
daily-webapp	Ready	Preview	Mar 23, 2026 3:44pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
storybook	Ignored		Mar 23, 2026 3:44pm

tomeredlich · 2026-03-23T12:49:23Z

@claude check pr

claude · 2026-03-23T12:49:36Z

Claude finished @tomeredlich's task in 3m 16s —— View job

PR Review

Gather context
Read changed files
Analyze and post review

Summary

The fix adjusts the in-feed hero insertion index by -1 when a pre-feed slot card (profile completion or brief) is present. This is consistent with the existing indexWhenShowingPromoBanner pattern (line 600) which already applies the same Number(showFirstSlotCard) offset.

Why the fix is correct: heroInsertIndex is calculated as Math.ceil(HERO_INSERT_INDEX / itemsPerRow) * itemsPerRow — a multiple of itemsPerRow, targeting a row boundary. When a pre-feed card occupies 1 grid slot before the items, every item shifts right by 1 slot in the grid. Subtracting 1 from the insertion index re-aligns the hero to the correct row boundary. Verified for 1, 2, 3, and 4 column layouts.

Issues

Minor: shouldShowInFeedHero guard is stale after the adjustment

In useReadingReminderFeedHero.ts:97:

itemCount > heroInsertIndex;  // e.g. itemCount > 6

But now the hero is actually inserted at adjustedHeroInsertIndex (e.g., 5 when showFirstSlotCard is true). The guard should be itemCount > adjustedHeroInsertIndex in that case. The practical impact: when showFirstSlotCard === true and itemCount === heroInsertIndex exactly (e.g., exactly 6 items), the hero won't show even though the adjusted position (index 5) is valid. This is a narrow edge case and doesn't block the PR — just worth noting.

Fix this →

Looks good

Math.max(..., 0) guard correctly prevents negative indices
Mutually exclusive pre-feed card rendering (showBriefCard && !showProfileCompletionCard) means firstGridSlotOffset is always 0 or 1 — no double-counting
Scope is tight — only Feed.tsx touched
Approach is consistent with how indexWhenShowingPromoBanner already handles the same offset

Pass the first feed-slot offset into the reminder hook and use the adjusted index for inline hero visibility checks, so edge cases with a pre-feed card still render consistently. Made-with: Cursor

Align reminder widget interactions with latest UI updates by removing the inline notification CTA, updating quick option labels, and preventing overflow in the options row. Also normalize enable-notification action alignment in modal CTA rendering. Made-with: Cursor

Keep in-feed hero placement after card rows while allowing debug mode to bypass homepage and scroll gates for easier QA. Also ensure the close action still hides the hero during the current session in debug mode. Made-with: Cursor

tomeredlich · 2026-03-23T15:42:32Z

@claude check pr

claude · 2026-03-23T15:42:46Z

Claude finished @tomeredlich's task in 2m 5s —— View job

PR Review

Gather context
Read changed files
Analyze and post review

Summary

The PR fixes in-feed hero row alignment when a pre-feed slot card (profile completion or brief) is present. The approach is sound and consistent with the existing indexWhenShowingPromoBanner offset pattern.

Core Fix — Feed.tsx + useReadingReminderFeedHero.ts

The fix is correct. firstSlotOffset is now passed into the hook, which computes adjustedHeroInsertIndex = Math.max(heroInsertIndex - firstSlotOffset, 0) and uses it both for the shouldShowInFeedHero guard (line 106) and for the render index check in Feed.tsx (lines 594–597). The two computations use the same firstSlotOffset, so they stay in sync.

One minor note: adjustedHeroInsertIndex is computed twice — once inside the hook (for the guard) and once in Feed.tsx (for rendering). The hook still returns the unadjusted heroInsertIndex, which Feed.tsx only uses to re-derive the adjusted value. It would be slightly cleaner to return adjustedHeroInsertIndex from the hook directly and remove the recomputation in Feed.tsx, but this is low-priority. The current behavior is correct.

notificationExperimentDebug.ts (new file)

Well-structured debug utility. Properly gates behind isDevelopment, uses query params with localStorage persistence, and handles localStorage failures gracefully. No issues.

Remaining Files

EnableNotification.tsx (+45/-26): Notification experiment copy/layout additions. Logic is coherent, source-based branching is consistent with the existing pattern.
PostReminderOptions.tsx, PostContentReminder.tsx, useReadingReminderHero.ts: Minor cleanups, no issues observed.

Scope Note

The PR description says "scope change to feed placement logic only (Feed.tsx)" but 7 files changed. The additional changes appear to be legitimate polish bundled in the same branch — worth keeping the description accurate for future reference, but not a blocker.

Overall: looks good. The stale-guard issue from the previous review has been addressed. The fix is correct and well-scoped.

idoshamun · 2026-03-23T20:07:23Z

packages/shared/src/components/notifications/EnableNotification.tsx

  label,
  onEnableAction,
 }: EnableNotificationProps): ReactElement | null {
+  const [isDismissedLocally, setIsDismissedLocally] = useState(false);


Why did you introduce state instead of using onDismiss directly?

idoshamun · 2026-03-23T20:09:07Z

packages/shared/src/hooks/notifications/notificationExperimentDebug.ts

@@ -0,0 +1,136 @@
+import { isDevelopment } from '../../lib/constants';


We should delete this file

fix(shared): preserve card sequence with in-feed reminder hero

1c5b5f6

Adjust in-feed hero insertion index to account for pre-feed slot cards so the hero renders in its own row without breaking card order. Made-with: Cursor

vercel bot deployed to Preview – daily-webapp March 23, 2026 12:52 View deployment

fix: align in-feed reminder visibility guard with rendered index

2372dde

Pass the first feed-slot offset into the reminder hook and use the adjusted index for inline hero visibility checks, so edge cases with a pre-feed card still render consistently. Made-with: Cursor

idoshamun approved these changes Mar 23, 2026

View reviewed changes

vercel bot deployed to Preview – daily-webapp March 23, 2026 13:06 View deployment

Merge branch 'main' into fix/in-feed-hero-row-sequence

ad26c62

vercel bot deployed to Preview – daily-webapp March 23, 2026 13:10 View deployment

vercel bot deployed to Preview – daily-webapp March 23, 2026 15:35 View deployment

vercel bot deployed to Preview – daily-webapp March 23, 2026 15:44 View deployment

idoshamun reviewed Mar 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(shared): preserve card sequence with in-feed reminder hero#5780

fix(shared): preserve card sequence with in-feed reminder hero#5780
tomeredlich wants to merge 5 commits intomainfrom
fix/in-feed-hero-row-sequence

tomeredlich commented Mar 23, 2026 •

edited by github-actions bot

Loading

Uh oh!

vercel bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

tomeredlich commented Mar 23, 2026

Uh oh!

claude bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

tomeredlich commented Mar 23, 2026

Uh oh!

claude bot commented Mar 23, 2026 •

edited

Loading

Uh oh!

idoshamun Mar 23, 2026

Uh oh!

idoshamun Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,136 @@
		import { isDevelopment } from '../../lib/constants';

Conversation

tomeredlich commented Mar 23, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Preview domain

Uh oh!

vercel bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tomeredlich commented Mar 23, 2026

Uh oh!

claude bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Summary

Issues

Looks good

Uh oh!

tomeredlich commented Mar 23, 2026

Uh oh!

claude bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Summary

Core Fix — Feed.tsx + useReadingReminderFeedHero.ts

notificationExperimentDebug.ts (new file)

Remaining Files

Scope Note

Uh oh!

idoshamun Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

idoshamun Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tomeredlich commented Mar 23, 2026 •

edited by github-actions bot

Loading

vercel bot commented Mar 23, 2026 •

edited

Loading

claude bot commented Mar 23, 2026 •

edited

Loading

claude bot commented Mar 23, 2026 •

edited

Loading