refactor plan parsing - #788
Merged
Merged
Conversation
pgiraud
reviewed
Aug 19, 2025
In PlanService.fromSource() we were JSON parsing the source value to determine if it was valid JSON and then passing the original source to parseJson() which again parsed that value. We now only parse the value once before calling this parseJson() method. That method is renamed as getPlanContent(), made private and its inaccurate comment is removed.
PlanService.createPlan() declares its `planContent` parameter as an `IPlanContent` type, which must have a `Plan` property, but also checks its presence. Instead, move this check at parse stage so as to make the assumptions consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes I found sensible (but might not) while reviewing (getting familiar with) the code.