tests e2e with Playwright#917
Open
MarionGiusti wants to merge 6 commits into
Open
Conversation
MarionGiusti
force-pushed
the
marion_e2e_playwright
branch
2 times, most recently
from
70bc55d to
51b70e1
Compare
MarionGiusti
force-pushed
the
marion_e2e_playwright
branch
from
51b70e1 to
1cba4c6
Compare
pgiraud
reviewed
Jun 25, 2026
Member
|
Errors like: |
pgiraud
reviewed
Jun 25, 2026
|
|
||
| test('switches to dark mode', async ({ page }) => { | ||
| await page.getByTitle('Switch to dark mode').click(); | ||
| await expect(page).toHaveScreenshot('plan_darkMode.png'); |
Member
There was a problem hiding this comment.
I'm not sure if an argument is needed here.
Collaborator
Author
There was a problem hiding this comment.
I don’t understand which argument you are referring to. page ?
Member
There was a problem hiding this comment.
No, I was referring to the argument for toHaveScreenshot. As far as I understand, it's not mandatory and playwright will create a name automatically. To be checked.
MarionGiusti
force-pushed
the
marion_e2e_playwright
branch
4 times, most recently
from
20cafed to
2231fea
Compare
Member
|
I think it would be nice to separate e2e and visual regression (those with snapshots) tests. The former shouldn't require docker, while the latter probably does. |
pgiraud
reviewed
Jul 1, 2026
MarionGiusti
force-pushed
the
marion_e2e_playwright
branch
7 times, most recently
from
e0d8855 to
3b50f5a
Compare
pgiraud
reviewed
Jul 7, 2026
Exclude e2e and node_modules from Vitest config. Ensure consistent results between local and CI by running visual tests inside a Playwright Docker container. Use Firefox only for Playwright in Docker.
MarionGiusti
force-pushed
the
marion_e2e_playwright
branch
from
3b50f5a to
0f18ae9
Compare
pgiraud
force-pushed
the
marion_e2e_playwright
branch
from
8729d00 to
f10afe9
Compare
Instead of a custom image. The Noto fonts are not installed but this should not be a problem. We also make sure that the test-results and playwright-report folders created by playwright to be owned by host user. The report is automatically available after running test. No need to run an extra command. This required to expose the 9323 port.
pgiraud
force-pushed
the
marion_e2e_playwright
branch
2 times, most recently
from
aa5bbdf to
69c34c1
Compare
pgiraud
force-pushed
the
marion_e2e_playwright
branch
from
69c34c1 to
25a2e3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.