Metadata table v2 #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb55
force-pushed
the
metadata
branch
4 times, most recently
from
901ad7d to
a31a3cb
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
5743
to
6179
| case NDB_WRITER_NOTE_META: | ||
| break; |
There was a problem hiding this comment.
The NDB_WRITER_NOTE_META case is empty and does not call any handler function. This means note metadata writes will be silently ignored instead of being processed.
jb55
force-pushed
the
metadata
branch
2 times, most recently
from
4d5970b to
f7bce64
Compare
Signed-off-by: William Casarin <[email protected]>
these had wrong function names in them Signed-off-by: William Casarin <[email protected]>
jb55
force-pushed
the
metadata
branch
6 times, most recently
from
09555a6 to
b1053b8
Compare
Signed-off-by: William Casarin <[email protected]>
this is needed for the metadata table Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Add online counting for: - quotes - thread replies - direct replies - total reactions only for kind1 and longform for now Signed-off-by: William Casarin <[email protected]>
also verify it matches the online counting
Signed-off-by: William Casarin <[email protected]>
jb55
force-pushed
the
metadata
branch
2 times, most recently
from
ca03306 to
c1a785d
Compare
Signed-off-by: William Casarin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is v2 of the metadata table. Before we used flatbuffers, but here we switch to a custom table design with an API.
See docs/metadata.md for the design