Error middleware enhancement #770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgerlag
requested changes
Apr 5, 2021
| /// <param name="ex">The exception to handle</param> | ||
| /// <returns>A task that completes when handling is done.</returns> | ||
| Task HandleAsync(Exception ex); | ||
| Task HandleAsync(WorkflowInstance workflowInstance, Exception ex); |
There was a problem hiding this comment.
How can we make this backward compatible?
There was a problem hiding this comment.
@danielgerlag I can introduce something like IWorkflowMiddlewareErrorHandlerV2 that will have an old and a new method. And update the usages. However, I don't like this approach. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a WorkflowInstance parameter to
IWorkflowMiddlewareErrorHandlerinterface so that it's possible to log only exception, but also related workflow information like ID:WARNING: this is a breaking change in terms that any 3rd party implementations of IWorkflowMiddlewareErrorHandler won't work without changes.