allow to read longer files from stdin#364
Open
anentropic wants to merge 1 commit intodanielgtaylor:masterfrom
Open
allow to read longer files from stdin#364anentropic wants to merge 1 commit intodanielgtaylor:masterfrom
anentropic wants to merge 1 commit intodanielgtaylor:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to read large blueprints from stdin fails, giving a syntax error which suggests the content was truncated. Reading the same file in via
-i <filename>method works fine, so there is no issue with the file itself.The length of the content I got was always 65536 bytes, suggesting some issue around buffering.
After experimenting it turns out that what actually happens is the
process.stdin.on 'readable'event handler gets called multiple times for large files - for each block of data from the buffer.So the fix is to build up the blueprint content over a series of
readableevents and wait until theendevent is triggered before trying to process it.