Add player name display option by starnotes-xj · Pull Request #4643 · danielkrupinski/Osiris

starnotes-xj · 2026-05-18T05:58:37Z

Summary

Add a player name panel for in-world player info.
Add configuration and UI options for player name display.
Update config compatibility tests and mocks for the new option.

Test plan

Not run; PR only includes the already committed local changes.

Generated with Claude Code

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a configurable "Player Name" display to the Player Info In World feature, including the new config variable, UI dropdown, panel rendering, and version-bumped config compatibility tests.

Changes:

Introduces PlayerNameEnabled config variable, schema entry, and v11 config compatibility expectations.
Adds PlayerNamePanel/PlayerNamePanelParams rendering pipeline plus PlayerController::getName() accessor.
Wires up the new dropdown in the Panorama UI (CreateGUI.js / VisualsTab.h).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Source/CS2/Classes/Entities/CCSPlayerController.h	Adds `m_sSanitizedPlayerName` schema alias.
Source/GameClient/Entities/PlayerController.h	Adds `getName()` using offset from player color.
Source/Features/Visuals/PlayerInfoInWorld/PlayerNamePanel.h	New panel updating label with player name.
Source/Features/Visuals/PlayerInfoInWorld/PlayerNamePanelParams.h	Visual styling params for the name label.
Source/Features/Visuals/PlayerInfoInWorld/PlayerInfoInWorldPanelFactory.h	Factory method to create the new label panel.
Source/Features/Visuals/PlayerInfoInWorld/PlayerInfoPanelTypes.h	Registers `PlayerNamePanel` in panel tuple.
Source/Features/Visuals/PlayerInfoInWorld/PlayerInfoInWorldConfigVariables.h	Adds `PlayerNameEnabled` config var.
Source/Config/ConfigVariableTypes.h	Registers new variable in the type list.
Source/Config/ConfigSchema.h	Adds JSON (de)serialization for `PlayerName`.
Source/UI/Panorama/VisualsTab.h	Hooks up the new dropdown handler.
Source/UI/Panorama/CreateGUI.js	Adds Player Name section to UI.
Tests/Configs/config_current.cfg	Updates current config fixture with `PlayerName`.
Tests/FunctionalTests/Config/ConfigCompatibilityTests.cpp	Adds v11 expectations layer.
Tests/Mocks/MockPlayerController.h	Adds `getName` mock method.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

starnotes-xj · 2026-05-18T06:07:27Z

@copilot apply changes based on the comments in this thread

Use a dedicated player-name offset pattern so the name field no longer depends on the player color field layout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Revert the incorrect sanitized-name pattern so the player name display uses the working offset path again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

starnotes-xj · 2026-05-31T05:16:47Z

@mdilai @ClaudiuHKS @Heyter @molendus1001

- 从PlayerInfoPanelTypes（脚部面板）中移除PlayerNamePanel - 在InWorldPanels中添加单独的PlayerNamePanel池 - 修复面板创建问题：使用容器+标签子级模式，而不是仅使用标签 - 使用多级回退机制更新PlayerController::getName()方法 - 修复了OffsetToPlayerColor和UiItem3dPanel的过时Windows样式 - 添加build-release.ps1便捷构建脚本

danielkrupinski · 2026-05-31T16:26:01Z

Recent commits are going in the wrong direction, so I will comment on 0dc0c82:

The text is hardly readable - you should change the font style, probably size and weight
Some player names differ from the scoreboard - e.g. bot names. Player names should be the same as on the scoreboard and killfeed.
Player name probably looks better when placed below player health
Option to change player name color (e.g. team color or health-based) should be added (unless it would affect text readability).

- Improve readability: larger font, black weight, stronger shadow - Prefer sanitized name to match scoreboard/killfeed (e.g. bot names) - Render name below health via container child, reverting the independent world-space projection - Add name color option (white / team color / health-based) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

- Pattern scan logging: write all not-found patterns with module name and index to %APPDATA%/OsirisCS2/pattern_scan.log before hooks initialization, preventing silent crash on null pointer dereference - i18n: add Language config variable (enum class), translations for ~130 UI strings, language toggle button (EN/中文) in navbar, live label refresh via $.Osiris.registerTranslatable() / refreshLanguage() - Config variables now support enum class types via existing code path - Add /utf-8 MSVC flag for Chinese character support in source files Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

starnotes-xj · 2026-06-01T07:41:23Z

Thanks for the review! All the requested changes have been addressed:

Font readability - Updated font style, size and weight for better readability
Player name consistency - Player names now match the scoreboard and killfeed (including bot names)
Name placement - Player name is now positioned below player health
Name color options - Added configurable player name color modes: White, Team Color, and Health-based

Additionally, this update includes:

Pattern scan crash diagnostics - Logs all pattern scan failures with module name and index to %APPDATA%/OsirisCS2/pattern_scan.log before hooks initialization, making it easier to diagnose crashes caused by outdated signatures
Chinese/English i18n - Full UI translation support with a language toggle button (EN/中文) in the navbar, ~130 translated strings, and live label refresh on language switch. Language preference is persisted in config.

Let me know if there's anything else that needs adjustment!

starnotes-xj · 2026-06-01T07:42:41Z

@danielkrupinski

Previously flushLogToFile() returned early when logWritePos == 0, so no log file was created when all patterns were found successfully. Now it always writes a summary line (OK or count of failures). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

starnotes-xj · 2026-06-02T12:57:22Z

@mdilai @ClaudiuHKS @Heyter

新增玩家名称显示选项及相关配置

5a53364

Copilot AI review requested due to automatic review settings May 18, 2026 05:58

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread Source/GameClient/Entities/PlayerController.h Outdated

Comment thread Source/GameClient/Entities/PlayerController.h Outdated

Potential fix for pull request finding

09ebfde

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

starnotes-xj and others added 2 commits May 18, 2026 14:33

Resolve player name offset independently

932e88f

Use a dedicated player-name offset pattern so the name field no longer depends on the player color field layout. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Restore player name lookup

0dc0c82

Revert the incorrect sanitized-name pattern so the player name display uses the working offset path again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

starnotes-xj and others added 3 commits May 31, 2026 22:28

Merge branch 'master' into master

ea89132

Add player name display feature and pattern scan fixes

ae1e14a

starnotes-xj and others added 2 commits June 1, 2026 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add player name display option#4643

Add player name display option#4643
starnotes-xj wants to merge 10 commits into
danielkrupinski:masterfrom
starnotes-xj:master

starnotes-xj commented May 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

starnotes-xj commented May 18, 2026

Uh oh!

starnotes-xj commented May 31, 2026

Uh oh!

danielkrupinski commented May 31, 2026 •

edited

Loading

Uh oh!

starnotes-xj commented Jun 1, 2026

Uh oh!

starnotes-xj commented Jun 1, 2026

Uh oh!

starnotes-xj commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

starnotes-xj commented May 18, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

starnotes-xj commented May 18, 2026

Uh oh!

starnotes-xj commented May 31, 2026

Uh oh!

danielkrupinski commented May 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

starnotes-xj commented Jun 1, 2026

Uh oh!

starnotes-xj commented Jun 1, 2026

Uh oh!

starnotes-xj commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danielkrupinski commented May 31, 2026 •

edited

Loading