fix: resolve WebUI tooltips not rendering due to overflow clipping #1904
Conversation
Use position: fixed and getBoundingClientRect() to calculate tooltip position dynamically. This prevents tooltips from being clipped by parent containers with overflow: hidden (such as slide transitions). Closes danielmiessler#1790 Signed-off-by: majiayu000 <[email protected]>
|
Merry Christmas! Will look at this soon. |
- Extract positioning calculations into dedicated `positioning.ts` module - Add reactive tooltip position updates on scroll/resize - Improve accessibility with `aria-describedby` and unique IDs - Add SSR safety with `isBrowser` flag check - Replace inline position calculation with reactive statement - Add window event listeners for position tracking - Update unit tests to use extracted functions - Add test coverage for style formatting function
ksylvan
force-pushed
the
fix/webui-tooltips-rendering-1790
branch
from
655eb67 to
4d0e1e7
Compare
ksylvan
left a comment
ksylvan
left a comment
There was a problem hiding this comment.
Approved with some refactoring. Thanks, @majiayu000 !!!
|
Thanks for the review and refactoring improvements! Merry Christmas! 🎄 |
|
@majiayu000 How would you like to tackle this request? #680 |
Wait minutes. |
|
@ksylvan I've created a PR to address #680: #1907 The implementation adds a Session ID input field to the GUI, allowing users to:
However, I have some UI design concerns:
I'd appreciate feedback on whether this UI approach aligns with the project's design philosophy, or if there's a preferred way to integrate this feature. |
|
@majiayu000 I reviewed it and requested some changes. Thanks for your contribution! |
2 participants
What this Pull Request (PR) does
Fixes tooltip visibility issue in WebUI Model Controls by using
position: fixedpositioning instead ofposition: absolute.Problem: Tooltips were being clipped by parent containers with
overflow: hidden(caused by Svelte slide transitions).Solution: Calculate tooltip position using
getBoundingClientRect()and apply fixed positioning to escape overflow constraints.Related issues
Closes #1790
Screenshots
The tooltip now correctly renders above the parent container boundaries.