Conversation
The purpose of this commit is to remove the code from the activate() and open() functions, as well as scrap the setup_app_actions(). The new shell uses completely different code. This commit exists to help dealing with the possible conflicts when the branch is rebased on top of the current trunk.
danirod
added a commit
that referenced
this pull request
Aug 22, 2025
The settings window used to be an AdwPreferenceDialog; now it's a standard AdwWindow that presents a NavigationSplitView. Reasons: 1. It has to happen anyway in order to move to multiple windows (#258, #266). The new window actually uses the proposed system: there is a Shell and it gets added to an anonymous window. 2. More options will be added soon, so more space will be needed anyway (#190, #136, #265, #268). I don't feel comfortable adding more PreferencePages, so there's that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements a new shell for Cartero. It will change the application windows and the content chrome (the toolbar). This is NOT an occasion to rewrite additional panels, as the new shell is going to continue using the EndpointPane that is just refactored.
The goals of this PR are: