fixed #13743 - FP AssignmentAddressToInteger for double cast #7417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
firewave
commented
Mar 31, 2025
Comment on lines
-1347
to
-1348
| tok.varId(17); | ||
| tok.str("var1"); |
There was a problem hiding this comment.
str() clears the varid so this test was pointless.
firewave
force-pushed
the
up-prop-zz
branch
2 times, most recently
from
18cb901 to
59360ae
Compare
| @@ -8495,6 +8497,24 @@ class TestTokenizer : public TestFixture { | |||
| ASSERT_NO_THROW(tokenizeAndStringify(code)); | |||
| ASSERT_EQUALS("void ( * const f ) ( ) ;", tokenizeAndStringify("typedef void (*fp_t)(); fp_t const f;")); | |||
| } | |||
|
|
|||
| void simplifyPlatformTypes() { | |||
There was a problem hiding this comment.
Shouldn't these tests go here? #7416
There was a problem hiding this comment.
They used to be there but I included them here to have more coverage of the various parts of the code which triggered the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.