Tokenizer: provide TokenList in constructor
#7468
Open
+130
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Apr 15, 2025
Comment on lines
-1224
to
+1233
| ErrorMessage errmsg = ErrorMessage::fromInternalError(e, &tokenizer.list, file.spath()); | ||
| ErrorMessage errmsg = ErrorMessage::fromInternalError(e, nullptr, file.spath()); |
There was a problem hiding this comment.
Since TokenList might throw InternalError it seem strange that we pass that object into the exception handling. Also it was no longer available.
firewave
commented
Apr 15, 2025
Comment on lines
+1200
to
+1203
| } catch (const InternalError &e) { | ||
| ErrorMessage errmsg = ErrorMessage::fromInternalError(e, &tokenizer.list, file.spath()); | ||
| mErrorLogger.reportErr(errmsg); | ||
| } |
There was a problem hiding this comment.
The multiple layers of exception handling seem excessive. I think it is possible to clean this up a bit but that requires test coverage first.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.